Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use asgi name and version for tracer/meter for instrumentations using Asgi Middleware #2580

Merged
merged 19 commits into from
Jun 6, 2024

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jun 5, 2024

From comment

For instrumentations that use asgi OtelMiddleware as an implementation detail, we want to use the __name__ and __version__ of the originating instrumentation instead of the inner opentelemetry-instrumentation-asgi for the tracer and meter components used.

@lzchen lzchen requested a review from a team June 5, 2024 23:12
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe add a test in the asgi implementation to assert that?

@lzchen
Copy link
Contributor Author

lzchen commented Jun 6, 2024

@xrmx

Done

@lzchen lzchen merged commit 5b84128 into open-telemetry:main Jun 6, 2024
314 checks passed
@lzchen lzchen deleted the asgi branch June 6, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants