Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capture to open file descriptors in system metrics instrumentation #2652

Merged
merged 8 commits into from
Jul 5, 2024
Merged

Add capture to open file descriptors in system metrics instrumentation #2652

merged 8 commits into from
Jul 5, 2024

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Jul 2, 2024 •
edited
Loading

Description

Fixes #2562

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

xrmx
xrmx reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a changelog entry

@emdneto emdneto requested a review from a team July 2, 2024 15:34
@emdneto emdneto mentioned this pull request Jul 3, 2024
Open
@ocelotl ocelotl merged commit c4c9b6b into open-telemetry:main Jul 5, 2024
379 checks passed
@xrmx xrmx mentioned this pull request Jul 11, 2024
Closed
11 tasks
@jenshnielsen jenshnielsen mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

@lzchen lzchen lzchen left review comments

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

looks like process.open_file_descriptor.count is not implemented in python
4 participants
@emdneto @xrmx @ocelotl @lzchen