Fix http clients method attribute in case of non standard http methods #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
changed the title
emdneto
force-pushed
the
fix/http-clients-method-attribute
branch
2 times, most recently
from
e676850
to
3ff4a78
Compare
…y-python-contrib into fix/http-clients-method-attribute
lzchen
reviewed
Jul 22, 2024
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Show resolved
Hide resolved
lzchen
reviewed
Jul 22, 2024
...pentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py
Show resolved
Hide resolved
lzchen
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have the http.method attribute in spans for non-standard HTTP methods as HTTP instead of _OTHER . I identified instrumentations affected are requests, aiohttp-client and httpx
Right now, he have this in case of requests using nonstandard http methods, will generate span:
http.method: "HTTP"And we must have:
http.method: "_OTHER"For new semconv we must have in case of a request with method="NONSTANDARD":
http.request.method: "_OTHER"http.request.method_original: "NONSTANDARD"See https://github.com/open-telemetry/semantic-conventions/blob/main/docs/attributes-registry/http.md and https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#name