Fix description of http.server.duration and http.server.request.duration #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Pan <jianqiao.pan@fmr.com>
lzchen
approved these changes
Aug 23, 2024
|
Please add a CHANGELOG entry, rebase to the latest main and also enable maintainer edits so we can rebase for you! |
emdneto
reviewed
Aug 23, 2024
...tation/opentelemetry-instrumentation-wsgi/src/opentelemetry/instrumentation/wsgi/__init__.py
Show resolved
Hide resolved
emdneto
approved these changes
Aug 26, 2024
xrmx
approved these changes
Aug 26, 2024
kayhern
force-pushed
the
http-server-duration
branch
from
21af3ac
to
a17d93b
Compare
ocelotl
approved these changes
Aug 27, 2024
|
@StevenPenn please allow maintainers to edit your PR so that we can rebase it on |
|
Hi @lzchen, I've updated the change log file. |
|
Unfortunately every time we merge another change you will have to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the description of "http.server.duration" and "http.server.request.duration" is not inconsistent with opentelemetry offical document.
https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/#http-server-duration-metric
Fixes #2753
#2753
Type of change
How Has This Been Tested?
Test it in aiohttp-server, asgi, django, falcon, flask, pyramid, tornado, wsgi
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.