Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CorrelationContext to Baggage #1060

Merged
merged 9 commits into from
Sep 2, 2020

Conversation

ffe4
Copy link
Contributor

@ffe4 ffe4 commented Aug 31, 2020

Description

Most of this PR is just renaming in response to spec#857. I also removed some unused imports and changed the header name to otcorrelations, which has been specified in the spec for a while I think. The header name will probably soon change again, however (spec#879).

Fixes #1041

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been updated
  • Documentation has been updated

@ffe4 ffe4 marked this pull request as ready for review August 31, 2020 20:52
@ffe4 ffe4 requested a review from a team August 31, 2020 20:52
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple suggestions 👍

docs/api/api.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@codeboten codeboten merged commit e650fe7 into open-telemetry:master Sep 2, 2020
@ffe4 ffe4 deleted the issue_1041_baggage branch September 2, 2020 21:44
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Baggage specs for GA
4 participants