Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do full Sphinx build every time to not hide errors. #322

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Dec 9, 2019

See https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-e and https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-a. Otherwise, if you run the build two times, most warnings from the first build will be silently ignored if you didn't change the affected files.

@Oberon00
Copy link
Member Author

Oberon00 commented Dec 9, 2019

BTW, should this be "every time" instead of "everytime"?

@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #322 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   85.74%   85.88%   +0.14%     
==========================================
  Files          33       33              
  Lines        1613     1630      +17     
  Branches      181      182       +1     
==========================================
+ Hits         1383     1400      +17     
  Misses        182      182              
  Partials       48       48
Impacted Files Coverage Δ
...app/src/opentelemetry_example_app/flask_example.py 100% <0%> (ø) ⬆️
...src/opentelemetry/ext/opentracing_shim/__init__.py 95.86% <0%> (+0.17%) ⬆️
...xt-jaeger/src/opentelemetry/ext/jaeger/__init__.py 85.18% <0%> (+0.18%) ⬆️
...ry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py 90.54% <0%> (+0.26%) ⬆️
...ts/src/opentelemetry/ext/http_requests/__init__.py 89.18% <0%> (+0.3%) ⬆️
opentelemetry-sdk/src/opentelemetry/sdk/util.py 85.88% <0%> (+0.34%) ⬆️
...opentelemetry/sdk/context/propagation/b3_format.py 84.61% <0%> (+0.61%) ⬆️
...ry-sdk/src/opentelemetry/sdk/resources/__init__.py 70.83% <0%> (+2.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d441b1...c01bb49. Read the comment docs.

@codeboten
Copy link
Contributor

Yup, needs a space, every time

@Oberon00 Oberon00 changed the title Do full Sphinx build everytime to not hide errors. Do full Sphinx build every time to not hide errors. Dec 9, 2019
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's make sure we don't hide errors

@c24t c24t merged commit 105fe2f into open-telemetry:master Dec 9, 2019
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants