Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around trace-context failures. #330

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Work around trace-context failures. #330

merged 1 commit into from
Dec 11, 2019

Conversation

Oberon00
Copy link
Member

Work around for #329.

@Oberon00 Oberon00 requested a review from a team December 11, 2019 09:47
@Oberon00 Oberon00 changed the title Work around build failures. Work around trace-context failures. Dec 11, 2019
@codecov-io
Copy link

codecov-io commented Dec 11, 2019 •
edited
Loading

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files          33       33           
  Lines        1666     1666           
  Branches      197      197           
=======================================
  Hits         1408     1408           
  Misses        201      201           
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25af7f...0008c98. Read the comment docs.

@Oberon00 Oberon00 added bug Something isn't working build & infra Issues related to build & infrastructure. priority:p0 Issues which require immediate action to stop bleeding and removed priority:p0 Issues which require immediate action to stop bleeding labels Dec 11, 2019
codeboten
codeboten approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

c24t
c24t approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @Oberon00

@c24t c24t merged commit 43c7ccd into open-telemetry:master Dec 11, 2019
c24t pushed a commit to c24t/opentelemetry-python that referenced this pull request Dec 11, 2019
@Oberon00 @c24t
Work around build failures (open-telemetry#330)
78b567f
@c24t c24t mentioned this pull request Dec 12, 2019
Merged
@dgzlopes dgzlopes mentioned this pull request Jan 11, 2020
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@OlivierAlbertini
feat(node-sdk): make config optional (open-telemetry#331)
e6d9986 
* feat(node-sdk): make config optional

closes open-telemetry#330

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@c24t c24t c24t approved these changes

Assignees
No one assigned
Labels
bug Something isn't working build & infra Issues related to build & infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oberon00 @codecov-io @codeboten @c24t