Allow importlib_metadata < 8 #3804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The existing strictness might relate to Python version differences discussed in #3234 and a similar open PR for the instrumentation library in open-telemetry/opentelemetry-python-contrib#2181. It might help to bring up this PR and these issues at the Python sig. |
|
Hi @frenzymadness , I brought this PR up at the Python SIG meeting today and we would prefer not to introduce a broad version support change at this time given the other issue and PR I've linked. |
|
@tammy-baylis-swi @frenzymadness I think we would be okay with simply incrementing the version to cover v7.1 instead of the broader less than 8. |
|
Closing as superseded by #3835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
importlib_metadata 7.1 is out. If you don't plan to update the configuration for every minor release, it might make sense to allow all versions 7.x.y. importlib_metadata is pretty stable so I'd not be afraid of any breaking changes.