Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: bump cap of importlib-metadata to 8.4.0 #4141

Closed

Conversation

tacaswell
Copy link

Description

Adjust cap on importlib-metadata. I agree with @antonpirker in preferring unpinned dependencies for tests, but followed the guidance #4089 and pinned to the newest released version.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

tox -e py312-test-opentelemetry-api,py311-test-opentelemetry-api,py310-test-opentelemetry-api,py39-test-opentelemetry-api,py38-test-open
telemetry-api

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tacaswell tacaswell requested a review from a team August 21, 2024 17:24
Copy link

linux-foundation-easycla bot commented Aug 21, 2024

CLA Not Signed

@tacaswell
Copy link
Author

I'll look at the CLA later, but as there is zero creativity or IP in this PR, if someone who has already signed the CLA wants to take over this PR I have absolutely no problem with than!

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 22, 2024
@tacaswell
Copy link
Author

I need to get Brookhaven National Lab to sign the CLA and/or figure out who internally is already a CLA manager. I have no estimate on how long this will take.

As I said above, I have no problem with this PR being closed and re-done by someone who already has a signed CLA.

@xrmx
Copy link
Contributor

xrmx commented Aug 22, 2024

I need to get Brookhaven National Lab to sign the CLA and/or figure out who internally is already a CLA manager. I have no estimate on how long this will take.

As I said above, I have no problem with this PR being closed and re-done by someone who already has a signed CLA.

Thanks for the PR, closing in favour of one with the CLA signed.

@xrmx xrmx closed this Aug 22, 2024
@tacaswell tacaswell deleted the mnt/bump_importlib-metadata branch August 22, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants