Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

django downgrade to 1.10 #717

Merged
merged 6 commits into from
May 25, 2020
Merged

django downgrade to 1.10 #717

merged 6 commits into from
May 25, 2020

Conversation

HiveTraum
Copy link
Contributor

Hi everyone!

This is very cheap correction to be able integration for django >= 1.10

@HiveTraum HiveTraum requested a review from a team May 21, 2020 07:45
codeboten
codeboten suggested changes May 21, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. I've managed to test it and it seems to work if I use Python 3.5. Only blocking on the question of adding other versions of python to the setup file.

ext/opentelemetry-ext-django/setup.cfg Show resolved Hide resolved
@HiveTraum HiveTraum requested a review from codeboten May 22, 2020 06:48
toumorokoshi
toumorokoshi approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

codeboten
codeboten approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@codeboten codeboten merged commit 93e7db8 into open-telemetry:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@toumorokoshi toumorokoshi toumorokoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HiveTraum @codeboten @toumorokoshi