Fix inconsistent metric usage of http.target #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Sep 21, 2022
reyang
added
area:semantic-conventions
cijothomas
approved these changes
Sep 21, 2022
trask
approved these changes
Sep 21, 2022
mateuszrzeszutek
approved these changes
Sep 22, 2022
…y-specification into http-metric-inconsistency
pyohannes
approved these changes
Sep 28, 2022
This was referenced Oct 7, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2335.
http.urlfrom http client metrics. There is no parameterized corollary tohttp.urland its unlikely that http client libraries would be able to provide a parameterized version.http.targetwithhttp.routein http server metrics.These changes align the semantics of attributes in http traces and metrics.