Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OTEL proto files and OTLP Exporter to match the changes in the metrics specifications #301

Merged
merged 1 commit into from
May 23, 2022

Conversation

vvydier
Copy link
Contributor

@vvydier vvydier commented May 23, 2022

Creating this PR again as the last one ( #300 ) failed on EasyCLA possibly due to incorrect user.email. I am setting git config user.email "vvydier@gmail.com" before git commit this time.
Description of the PR: Labels has been deprecated in open-telemetry/opentelemetry-proto#342 and attributes are now used in it's place. This was reported by @trevor-dialpad and the OTLP Exporter needed this change if a user uses opentelemetry-swift with along other otel sdk's or uses it with newer version of the otel-collector

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #301 (fda29a8) into main (1c648c1) will decrease coverage by 0.92%.
The diff coverage is 30.41%.

❗ Current head fda29a8 differs from pull request most recent head d720fa3. Consider uploading reports for the commit d720fa3 to get more accurate results

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   75.35%   74.42%   -0.93%     
==========================================
  Files         361      361              
  Lines       22569    22796     +227     
==========================================
- Hits        17006    16967      -39     
- Misses       5563     5829     +266     
Impacted Files Coverage Δ
...xporters/OpenTelemetryProtocol/proto/logs.pb.swift 0.00% <0.00%> (ø)
.../OpenTelemetryProtocol/proto/logs_service.pb.swift 0.00% <ø> (ø)
...rters/OpenTelemetryProtocol/proto/metrics.pb.swift 22.48% <ø> (+2.78%) ⬆️
...enTelemetryProtocol/proto/metrics_service.pb.swift 63.15% <ø> (ø)
...ters/OpenTelemetryProtocol/proto/resource.pb.swift 90.00% <ø> (ø)
.../OpenTelemetryProtocol/proto/trace_config.pb.swift 0.00% <0.00%> (ø)
...enTelemetryProtocol/proto/trace_service.grpc.swift 84.37% <ø> (ø)
...OpenTelemetryProtocol/proto/trace_service.pb.swift 63.15% <ø> (ø)
.../OpenTelemetryProtocol/metric/MetricsAdapter.swift 31.84% <10.90%> (-1.15%) ⬇️
...orters/OpenTelemetryProtocol/proto/common.pb.swift 38.56% <36.36%> (-11.82%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c648c1...d720fa3. Read the comment docs.

@nachoBonafonte nachoBonafonte merged commit 03d5cd3 into open-telemetry:main May 23, 2022
@nachoBonafonte
Copy link
Member

🚀

@vvydier
Copy link
Contributor Author

vvydier commented May 23, 2022

Thanks @nachoBonafonte! That was easy, after almost a week of trying to figure out the problem with the PR. I will make sure to set the user.email correctly before I make a commit next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants