(concurrentbatchprocessor): avoid breaking parent span if used in SDK export pipeline #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moh-osman3
force-pushed
the
mohosman/sdk-keep-root-context
branch
from
42ae2d6
to
cf45aa1
Compare
moh-osman3
requested review from
lquerel,
jmacd and
codeboten
as code owners
jmacd
reviewed
Dec 20, 2023
jmacd
approved these changes
Dec 20, 2023
moh-osman3
force-pushed
the
mohosman/sdk-keep-root-context
branch
from
4076f13
to
8b19594
Compare
moh-osman3
force-pushed
the
mohosman/sdk-keep-root-context
branch
from
8b19594
to
b7033e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks all incoming contexts for a given batch. If all contexts are the same, the parent context is no longer broken and is passed directly into
export. Otherwise, the parent context must be broken and links to the incoming contexts are attached to the new span context.This will help our efforts in debugging metrics SDKs because no longer breaking the parent span means we can see the latency of
concurrentbatchprocessor