Build with OTel Collector v0.92.0 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
approved these changes
Jan 10, 2024
jmacd
added a commit
that referenced
this pull request
Jan 17, 2024
Fixes #33. Fixes #37. Note: each of the OTel-Arrow stream definitions has the same, identical signature. Tests without-loss-of-generality use the Traces service method and client mocks in mock-based tests, as these in fact work for non-trace data because the signatures are identical. Removes the stream entirely and updates the receiver code as #135 did for the exporter. Note this also re-generates all the mock-based tests using go.uber.org/mock which is the new location for github.com/golang/mock. Two missing `Makefile` rules are saved, for the next time this needs to be done. Note: comments out one line of test in a test that is identical to the core OTLP receiver. Having spent nearly an hour trying to understand this, I can only say it is related to the OTel-Go metrics SDK and the Prometheus registry; the obsreport functionality is working and the test broke following #131 (and CI/CD did not work for unknown reasons). It may be failing due to static relationships in the Arrow tests that are not present in the core OTLP tests. This is recorded in #137.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is now easy. I manually edited the version in
collector/otelarrowcol-build.yaml, then ranmake genotelarrowcolwhich syncs dependencies within the repo.