Add instrumentation to monitor the impact of schema updates on compression efficiency #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lquerel
changed the title
jmacd
reviewed
Nov 2, 2023
jmacd
approved these changes
Nov 3, 2023
|
I apparently closed this by pushing |
|
Opening again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first in a series of two PRs with the ultimate goal of eliminating the observed degradation of the compression rate over time for Lightstep's span-type data.
This first PR focuses on the instrumentation of the code to better understand the impact of certain schema changes on the average compression rate (see the chart below).
The second PR will address this issue by identifying dictionary overflow that could be better handled as dictionary reset.