Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define what's in scope for OpenTelemetry Logs GA (post traces and metrics 1.0 GA) #130

Merged

Conversation

tigrannajaryan
Copy link
Member

Clearly defined scope is important to align all logs contributors and to make
sure we know what target we are working towards. Note that some of the listed
items are already fully or partially implemented but are still listed for
completeness.

This OTEP shows the initial scope proposal. Please suggest additions or changes
to the scope and I will include them in this PR.

@tigrannajaryan tigrannajaryan requested review from a team August 10, 2020 18:51
@tigrannajaryan tigrannajaryan changed the title Defines what's in scope for OpenTelemetry Logs 1.0 GA Define what's in scope for OpenTelemetry Logs 1.0 GA Aug 10, 2020
Clearly defined scope is important to align all logs contributors and to make
sure we know what target we are working towards. Note that some of the listed
items are already fully or partially implemented but are still listed for
completeness.
- Implement OpenTelemetry logs SDK for Java that support trace context
extraction from the current execution context.

- Implement appenders for Log4J using OpenTelemetry SDK that automatically
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Log4J and not SLF4J

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appenders are not part of the slf4j api, they are implementor specific (e.g. ch.qos.logback.core.Appender or org.apache.logging.log4j.core.Appender)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no particular preference for which Java logging library to support. I can change to SFL4J if it is a more popular/preferable library for the community.
The goal here is not to have comprehensive coverage of all Java application needs, but rather to set an example and clearly demonstrate how OpenTelemetry logging SDK can be used with a logging library.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say appenders for at least one of the major logging library?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point, let me rephrase to avoid mentioning a specific library. The decision on which library to support and how exactly does not need to happen right now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-worded, please check again.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it's important to have a solution that works generally- in the Java world, at least Log4j, Log4j2, Logback, and java.util.logging (though obviously we start with one).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I think the text now reflects this.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the understanding the Logs portion of OpenTelemetry was explicitly not a part of the upcoming GA. Has that changed?

@tigrannajaryan
Copy link
Member Author

I had the understanding the Logs portion of OpenTelemetry was explicitly not a part of the upcoming GA. Has that changed?

@MrAlias GA here means "whenever we decide to GA logs support", not the upcoming GA where only trace and metrics will be supported. I should probably remove the reference to 1.0 to avoid confusion.

@MrAlias
Copy link
Contributor

MrAlias commented Aug 11, 2020

I had the understanding the Logs portion of OpenTelemetry was explicitly not a part of the upcoming GA. Has that changed?

@MrAlias GA here means "whenever we decide to GA logs support", not the upcoming GA where only trace and metrics will be supported. I should probably remove the reference to 1.0 to avoid confusion.

Ah, gotcha. Thanks for the clarification 👍

@tigrannajaryan tigrannajaryan changed the title Define what's in scope for OpenTelemetry Logs 1.0 GA Define what's in scope for OpenTelemetry Logs GA (post traces and metrics 1.0 GA) Aug 11, 2020
@tigrannajaryan
Copy link
Member Author

@MrAlias I clarified what "GA" means in the doc.

FluentBit/FluentD.

- Add support for log data type to the following processors: `resource`,
`batch`, `attributes`, `k8s_tagger`, `resourcedetection`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about queued (Queued Retry)?

Copy link

@davidblondeau davidblondeau Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question for filter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

queued_retry is being deprecated and the equivalent functionality is moved to exporters (and support for logs already exists).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter is currently a metric-only processor. Not sure if logs support needs to be part of the GA. We probably need to add it for logs, but first it will probably happen for traces.

@bogdandrutu bogdandrutu merged commit 403377f into open-telemetry:master Aug 26, 2020
@tigrannajaryan tigrannajaryan deleted the feature/tigran/logscope branch August 26, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.