Add status to RFC template #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iredelmeier
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
bogdandrutu
reviewed
Aug 12, 2019
| @@ -1,5 +1,7 @@ | |||
| # Replace this with your awesome RFC title | |||
|
|
|||
| **Status:** `proposed` | |||
There was a problem hiding this comment.
Can we enumerate all the possible values? Maybe: draft, in-progress, approved?
There was a problem hiding this comment.
Definitely.
My thinking had been that proposed made sense for the template since that's the starting state.
Also, the possible states are enumerates here: https://github.com/open-telemetry/rfcs#the-rfc-life-cycle
There was a problem hiding this comment.
Maybe add an italicized comment w/ the URL spelled out, for reviewing the lifecycle?
There was a problem hiding this comment.
Sorry I did not see all the definitions there. Looks good.
jmacd
approved these changes
Aug 12, 2019
bogdandrutu
approved these changes
Aug 12, 2019
| @@ -1,5 +1,7 @@ | |||
| # Replace this with your awesome RFC title | |||
|
|
|||
| **Status:** `proposed` | |||
There was a problem hiding this comment.
Sorry I did not see all the definitions there. Looks good.
arminru
added a commit
to arminru/opentelemetry-rfcs
that referenced
this pull request
Aug 13, 2019
arminru
added a commit
to arminru/opentelemetry-rfcs
that referenced
this pull request
Aug 13, 2019
bogdandrutu
pushed a commit
that referenced
this pull request
Aug 13, 2019
bogdandrutu
pushed a commit
that referenced
this pull request
Aug 13, 2019
Oberon00
pushed a commit
to dynatrace-oss-contrib/oteps
that referenced
this pull request
Sep 16, 2019
* Copy OC specs into specification dir * Copy OT spec into specification/README.md * Remove work-in-progress files * Move specification/ into work_in_progress/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.