-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Separate Layer for Context Propagation #66
Merged
Merged
Changes from 1 commit
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
dff8df9
Proposal to separate context propagation from observability
tedsuo 5ad7d1c
cleanup description for Extract
tedsuo 1dc3c7b
commas
tedsuo 58248e6
Update text/0000-separate-context-propagation.md
tedsuo 68cb0ba
RFC proposal: A layered approach to data formats
tedsuo 3dc6a76
whitespace
tedsuo 459435e
Capitalization
tedsuo c9c64f4
whitespace
tedsuo c3c7c24
CleanBaggage -> ClearBaggage
tedsuo 4588096
move function descriptions to new line
tedsuo 2d80dae
Add Optional subheader
tedsuo 7a73210
cleanup rough edits
tedsuo 0d8e41b
clean up advice on pre-existing context implementations
tedsuo aad5605
Better context descriptions
tedsuo 4a930eb
remove data format file
tedsuo e1ef61f
remove git diff message
tedsuo f949435
improved code sytnax
tedsuo 1cb155e
stop stuttering
tedsuo 7b9e861
Update text/0000-separate-context-propagation.md
tedsuo 07eb397
spacing
tedsuo 0ebeb6c
Refine propagation
tedsuo 147d6b0
Add RFC ID number from PR
tedsuo 72d4651
remove RFC status line
tedsuo 1472197
slight calrification for GetHTTPExtractor
tedsuo 18a37d4
add global propagators
tedsuo 7ea1834
Clean up motivation
tedsuo 7317747
Clean up explanbation intro
tedsuo 43ba8fd
Clarify context types
tedsuo d7d6f1c
Fix ChainHTTPInjector and ChainHTTPExtractor
tedsuo 3a817a2
typo
tedsuo 3381e0f
Reference Trace-Context, not just traceparent
tedsuo c15a107
Bagge context cleanup
tedsuo 310e8d5
stronger language around context access
tedsuo f59fc27
Update text/0042-separate-context-propagation.md
tedsuo 153b9aa
clean up tradeoffs
tedsuo 10e7d60
v2.0 of this OTEP
tedsuo 40a3bd2
Update OTEP number for new submission
tedsuo 5151d3f
Update text/0066-separate-context-propagation.md
tedsuo bbbe41e
Link to Erlang prototype
tedsuo 6693f91
whitespace
tedsuo e5c0395
ToC
tedsuo af86fc6
Update text/0066-separate-context-propagation.md
tedsuo 716956a
more context examples
tedsuo 14d943f
typo
tedsuo 3dfa025
Update text/0066-separate-context-propagation.md
tedsuo fc4fd18
Apply suggestions from code review
tedsuo ef70b79
Renamed aspects to "cross-cutting concerns"
tedsuo 094817f
injectors are a list instead of chained
tedsuo 7a912ae
clean up API representation
tedsuo 865ebc2
cleanup examples
tedsuo 0c38469
typo
tedsuo ff5d999
remove correlations from proposal
tedsuo e9c075a
Merge branch 'master' into context-prop-2
tedsuo 5262aeb
Update text/0066-separate-context-propagation.md
tedsuo 3d0d1fb
remove the term "chaining"
tedsuo 2dbb2ca
remove the terms upstream and downstream
tedsuo 5e905b0
improved architecturural explanation
tedsuo f254372
whitespace
tedsuo fa23bf5
update link to Go prototype
tedsuo 762ab0a
Removed the Baggage API; replaced it with Correlations.
tedsuo 354a74c
Fix the intro paragraph for Correlations
tedsuo 8a09d99
Clarify that correltions must be propagated
tedsuo e009b65
Clarify risks
tedsuo b58e30d
removed extra header
tedsuo 3fa79e9
Clarify definition of aspect-oriented programming
tedsuo acc6d61
Fix RemoveCorrelation
tedsuo 2bab4da
Spelling
tedsuo 2386f06
Update text/0066-separate-context-propagation.md
tedsuo 286fb0a
Clarifying details
tedsuo 3f5ef37
Update python prototype
tedsuo 25a09ef
Update text/0066-separate-context-propagation.md
tedsuo a870519
Update text/0066-separate-context-propagation.md
tedsuo 036705b
Update text/0066-separate-context-propagation.md
tedsuo a12d245
Clarify that the APIs and example code are not meant as final. Add C…
tedsuo f306810
Inject returns headers, not context
tedsuo 4c605c9
Merge branch 'master' into context-prop-2
tedsuo b7efba5
Update text/0066-separate-context-propagation.md
tedsuo 630d954
spelling
tedsuo a43b5d7
remove spurious go comment
tedsuo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update text/0066-separate-context-propagation.md
Co-Authored-By: alrex <alrex.boten@gmail.com>
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember other motivation factors were things like context-based app and resource definition. Is it out of scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am leaving that out of scope here. Those changes are more like a static or lexical scope: how to apply the same set of resources to every "event" which occurs in a certain "region." This is focused solely on how to track and propagate execution context.
@jmacd and @danielkhan (and @bogdandrutu I think) are working on the resource/name-spacing issue separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trace context is one of the scopes for a resource. I want to make sure that justification covers this aspect.