Skip to content

Commit

Permalink
Rename jvm.classes.current_loaded to jvm.classes.count (#60)
Browse files Browse the repository at this point in the history
  • Loading branch information
trask committed Aug 16, 2023
1 parent 0669ca5 commit 3bd1c39
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ release.
([#249](https://github.com/open-telemetry/semantic-conventions/pull/249))
- Add `jvm.cpu.count` metric.
([#52](https://github.com/open-telemetry/semantic-conventions/pull/52))
- BREAKING: Rename `jvm.classes.current_loaded` metrics to `jvm.classes.count`
([#60](https://github.com/open-telemetry/semantic-conventions/pull/60))

## v1.21.0 (2023-07-13)

Expand Down
10 changes: 5 additions & 5 deletions docs/system/runtime-environment-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ semantic conventions when instrumenting runtime environments.
* [Metric: `jvm.threads.count`](#metric-jvmthreadscount)
* [Metric: `jvm.classes.loaded`](#metric-jvmclassesloaded)
* [Metric: `jvm.classes.unloaded`](#metric-jvmclassesunloaded)
* [Metric: `jvm.classes.current_loaded`](#metric-jvmclassescurrent_loaded)
* [Metric: `jvm.classes.count`](#metric-jvmclassescount)
* [Metric: `jvm.cpu.time`](#metric-jvmcputime)
* [Metric: `jvm.cpu.count`](#metric-jvmcpucount)
* [Metric: `jvm.cpu.recent_utilization`](#metric-jvmcpurecent_utilization)
Expand Down Expand Up @@ -260,18 +260,18 @@ This metric is obtained from [`ClassLoadingMXBean#getUnloadedClassCount()`](http
<!-- semconv metric.jvm.classes.unloaded(full) -->
<!-- endsemconv -->

### Metric: `jvm.classes.current_loaded`
### Metric: `jvm.classes.count`

This metric is [recommended][MetricRecommended].
This metric is obtained from [`ClassLoadingMXBean#getLoadedClassCount()`](https://docs.oracle.com/javase/8/docs/api/java/lang/management/ClassLoadingMXBean.html#getLoadedClassCount--).

<!-- semconv metric.jvm.classes.current_loaded(metric_table) -->
<!-- semconv metric.jvm.classes.count(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description |
| -------- | --------------- | ----------- | -------------- |
| `jvm.classes.current_loaded` | UpDownCounter | `{class}` | Number of classes currently loaded. |
| `jvm.classes.count` | UpDownCounter | `{class}` | Number of classes currently loaded. |
<!-- endsemconv -->

<!-- semconv metric.jvm.classes.current_loaded(full) -->
<!-- semconv metric.jvm.classes.count(full) -->
<!-- endsemconv -->

### Metric: `jvm.cpu.time`
Expand Down
4 changes: 2 additions & 2 deletions model/metrics/process-runtime-jvm-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ groups:
instrument: counter
unit: "{class}"

- id: metric.jvm.classes.current_loaded
- id: metric.jvm.classes.count
type: metric
metric_name: jvm.classes.current_loaded
metric_name: jvm.classes.count
brief: "Number of classes currently loaded."
instrument: updowncounter
unit: "{class}"
Expand Down
3 changes: 2 additions & 1 deletion schema-next.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ versions:
process.runtime.jvm.threads.count: jvm.threads.count
process.runtime.jvm.classes.loaded: jvm.classes.loaded
process.runtime.jvm.classes.unloaded: jvm.classes.unloaded
process.runtime.jvm.classes.current_loaded: jvm.classes.current_loaded
# https://github.com/open-telemetry/semantic-conventions/pull/60
process.runtime.jvm.classes.current_loaded: jvm.classes.count
process.runtime.jvm.cpu.time: jvm.cpu.time
process.runtime.jvm.cpu.recent_utilization: jvm.cpu.recent_utilization
process.runtime.jvm.memory.init: jvm.memory.init
Expand Down

0 comments on commit 3bd1c39

Please sign in to comment.