Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI Attributes to Sem Conv #832

Closed
adrielp opened this issue Mar 21, 2024 · 3 comments
Closed

Add CI Attributes to Sem Conv #832

adrielp opened this issue Mar 21, 2024 · 3 comments
Assignees
@jsuereth

Comments

@adrielp
Copy link
Contributor

adrielp commented Mar 21, 2024

Overvew

The CI/CD Working Group is looking to add semantic conventions for CI and CD Observability. This task serves to add the basic core attributes for continuous integration (builds).
jsuereth pushed a commit to jsuereth/semantic-conventions that referenced this issue Mar 28, 2024
@tigrannajaryan @bogdandrutu @jsuereth
Require that names and namespaces are one global space across all sem…
a59a1b2 
…antic convention areas (open-telemetry#832)

* Require that names and namespaces are one global space across all semantic convention areas

We have semantic conventions for Resources, Spans and Metrics (in the future also Logs are expected).
It was not clear if the attribute names across all convention areas should be globally unique.

This commit asserts that conventions are one space, they are not independent spaces with
their own namespaces each.

We prohibit using the same Span or Resource attribute name or metric label name but give them
slightly different meanings or value sets.

Resolves: open-telemetry/opentelemetry-specification#815

* Address PR comments

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
jsuereth pushed a commit to jsuereth/semantic-conventions that referenced this issue Mar 28, 2024
@tigrannajaryan @bogdandrutu @jsuereth
Require that names and namespaces are one global space across all sem…
a15b95d 
…antic convention areas (open-telemetry#832)

* Require that names and namespaces are one global space across all semantic convention areas

We have semantic conventions for Resources, Spans and Metrics (in the future also Logs are expected).
It was not clear if the attribute names across all convention areas should be globally unique.

This commit asserts that conventions are one space, they are not independent spaces with
their own namespaces each.

We prohibit using the same Span or Resource attribute name or metric label name but give them
slightly different meanings or value sets.

Resolves: open-telemetry/opentelemetry-specification#815

* Address PR comments

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
@adrielp adrielp mentioned this issue Apr 9, 2024
Closed
@arminru
Copy link
Member

arminru commented Jul 24, 2024 •
edited
Loading

@open-telemetry/semconv-cicd-approvers Can this be resolved now that #1075 (issue #915) was merged, or is this issue here intended to have a broader scope?

@adrielp
Copy link
Contributor Author

adrielp commented Jul 24, 2024

@arminru - I'll make a couple adjustments and clean up these now that that's been merged in. Thanks for checking!

@adrielp
Copy link
Contributor Author

adrielp commented Jul 25, 2024

Resolved now that #1075 was merged.

@adrielp adrielp closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuereth jsuereth

Labels
None yet
Projects
CI/CD SemConv SIG Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsuereth @arminru @adrielp