-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move common hardware attributes and metrics to registry #1030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a changelog entry.
cc @bertysentry |
@lmolkova I'm confused by your comments. I haven't created anything new. I have extracted hardware from one md file into yaml. As I stated in description I will do this in batches because there will be open questions and to make review easier, so I have extracted only first portion |
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
@trisch-me Thank you so much for taking the time to move the hardware semconv to YAML! (I was supposed to do it but couldn't find the time... and I was afraid the tooling wouldn't work well on some of the specificities of the hardware metrics, with common attributes, etc.). Let me know if you need any help with that! If you want to see these metrics in real life (to get a better understanding of their purpose and use), you can check these Grafana dashboards: Thanks! |
thanks @bertysentry for your comments. If you don't mind I will add you as reviewer to all my PRs related to the moving hw metrics to the yaml files/registry off-topic - I think we have met in the OTel booth during this Kubecon conference in Paris :) |
@trisch-me I confirm we met in Paris! It's funny when you realize usernames in GitHub are actual people! 😅 I'll be happy to review any PR on this topic! |
|
… into hardware_basic
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
We're not done yet! |
@lmolkova @bertysentry I have updated all the comments except the naming one. could you look once more |
Approved! Let's merge this so we can work the remaining issues! |
… into hardware_basic
… into hardware_basic
This is the first PR out of many for hardware metrics.
The first PR is about generic attributes used by all hardware metrics. I decided to split it into multiple PRs to make review easier because it's easy to miss something with a lot of changed files (I have started doing it with 5 metrics and lost myself track on things :) ).
I delete portions of
docs/system/hardware-metrics.md
file so that reviewers could see what has been changed now. This file will be deleted later as soon as it will be ported completely.Hardware wasn't moved to the yaml schema, so I'm doing here both introducing it to the registry and creating appropriate yaml files for each hardware metric
I need this PR merged before I will create other PRs (half of them is ready but based on this PR)
Merge requirement checklist
[chore]