Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define standard, vendor-agnostic, language-agnostic instrumentation identity attributes #1094

Conversation

michaelsafyan
Copy link
Contributor

Changes

Introduces instrumentation.source.* and instrumentation.distribution.* attributes to enable more triangulation of dependency libraries that have been instrumented with Open Telemetry and that construct the InstrumentationScope.

This is forked off from related pull request:

The related pull request includes GCP-specific attributes (e.g. gcp.client.service). Standard, common attributes were requested there. This pull request aims to provide the general, vendor-agnostic attributes requested.

Merge requirement checklist

@joaopgrassi
Copy link
Member

It almost seems like we need general conventions to define packages, package repositories and source code 🤔 .

@joaopgrassi
Copy link
Member

joaopgrassi commented Jun 19, 2024

We discussed this PR in the semantic conventions meeting (2024-06-17). Basically, we see the following issues/points to clarify:

  • Several attributes seem similar/relevant to CI/CD for example, target, repo. We can see those also being use there
  • Other attributes look like they also describe a general concept of a "package", like the name of the package, where one can find it.
  • Potential conflicts with scope name,version and artifact name/version

Copy link

github-actions bot commented Jul 5, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 5, 2024
@lmolkova
Copy link
Contributor

lmolkova commented Jul 9, 2024

Related: #1229

@pellared
Copy link
Member

Copy link

github-actions bot commented Aug 8, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 8, 2024
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants