Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added note about abbreviations #1121

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Conversation

trisch-me
Copy link
Contributor

Fixes #602

@trask FYI

Merge requirement checklist

@trisch-me trisch-me requested review from a team June 4, 2024 11:11
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

We should probably have a similar section on metrics - https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/metrics.md

Or maybe we should have a common section for all things related to naming

docs/general/attribute-naming.md Outdated Show resolved Hide resolved
docs/general/attribute-naming.md Outdated Show resolved Hide resolved
docs/general/attribute-naming.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think it's worthy of a changelog entry

@trisch-me trisch-me changed the title [chore] added note about abbreviations added note about abbreviations Jun 5, 2024
@trisch-me
Copy link
Contributor Author

done. markdown link is going crazy defining different urls for different PRs dead

@lmolkova lmolkova merged commit 3b7dd89 into open-telemetry:main Jun 6, 2024
12 checks passed
@trisch-me trisch-me deleted the abbr branch June 7, 2024 08:47
heyams pushed a commit to heyams/semantic-conventions that referenced this pull request Jun 11, 2024
* Declare freeze of Trace Specification 1.0

We want to freeze Trace specification 1.0 so that we no longer accept substantial changes (unless a fundamental problem is found in the spec).

Resolves open-telemetry/opentelemetry-specification#1120
heyams pushed a commit to heyams/semantic-conventions that referenced this pull request Jun 11, 2024
* Declare freeze of Trace Specification 1.0

We want to freeze Trace specification 1.0 so that we no longer accept substantial changes (unless a fundamental problem is found in the spec).

Resolves open-telemetry/opentelemetry-specification#1120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add guidance on abbreviation usage in semantic attribute names
4 participants