Clarify db.query.parameter is string representation #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
approved these changes
Jun 19, 2024
gregkalapos
approved these changes
Jun 19, 2024
maryliag
approved these changes
Jun 21, 2024
joaopgrassi
approved these changes
Jun 25, 2024
arminru
approved these changes
Jun 25, 2024
| @@ -25,7 +25,7 @@ This group defines the attributes used to describe telemetry in the context of d | |||
| | `db.namespace` | string | The name of the database, fully qualified within the server address and port. [2] | `customers`; `test.users` |  | | |||
| | `db.operation.batch.size` | int | The number of queries included in a [batch operation](/docs/database/database-spans.md#batch-operations). [3] | `2`; `3`; `4` |  | | |||
| | `db.operation.name` | string | The name of the operation or command being executed. [4] | `findAndModify`; `HMSET`; `SELECT` |  | | |||
| | `db.query.parameter.<key>` | string | The query parameters used in `db.query.text`, with `<key>` being the parameter name, and the attribute value being the parameter value. [5] | `someval`; `55` |  | | |||
| | `db.query.parameter.<key>` | string | A query parameter used in `db.query.text`, with `<key>` being the parameter name, and the attribute value being a string representation of the parameter value. [5] | `someval`; `55` |  | | |||
There was a problem hiding this comment.
#1157 would be helpful here as we'd then have "55" instead
arminru
added
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Clarify that
db.query.parameter.<key>is string representation of the parameter value.