Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to use weaver for code generation #1296

Merged

Conversation

lmolkova
Copy link
Contributor

Updates code generation supplementary guidelines to use weaver instead of build-tools.
Adds a section on migration.

See open-telemetry/build-tools#322 for the context.

@lmolkova lmolkova requested review from a team July 30, 2024 03:43
@lmolkova lmolkova marked this pull request as draft July 30, 2024 03:48
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for putting it together!

Left a few suggestions.

.chloggen/1296.yaml Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation.

docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
@lmolkova lmolkova marked this pull request as ready for review July 30, 2024 18:32
lmolkova and others added 6 commits July 30, 2024 11:32
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Co-authored-by: Laurent Quérel <laurent.querel@gmail.com>
@lmolkova lmolkova force-pushed the update-code-generation-to-weaver branch from 0d430de to bd3d35e Compare July 30, 2024 18:32
docs/non-normative/code-generation.md Outdated Show resolved Hide resolved
lmolkova and others added 2 commits July 31, 2024 22:11
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
@lmolkova lmolkova merged commit 69b0744 into open-telemetry:main Aug 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants