docs: explain deployment.environment impact on service identity #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why To clarify a likely misconception about service identity in the case of multiple environments. # What Explain that `deployment.environment` does not impact service identity. # References Fixes open-telemetry#119
joaopgrassi
reviewed
Nov 2, 2023
Oberon00
approved these changes
Nov 2, 2023
|
I think this is a good description of the current state. Maybe we should also add a note that service.namespace could be used to distinguish the services. A more major change would be to make the environment part of the service identity, although IMHO we should then rename the attribute to service.environment (or service.deployment_environment?). But that would be a whole separate issue/PR |
bripkens
force-pushed
the
main
branch
2 times, most recently
from
b754667
to
827004e
Compare
joaopgrassi
approved these changes
Nov 2, 2023
arminru
approved these changes
Nov 2, 2023
# Why To clarify a likely misconception about service identity in the case of multiple environments. # What Explain that `deployment.environment` does not impact service identity. # References Fixes open-telemetry#119
AlexanderWert
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To clarify a likely misconception about service identity in the case of multiple environments.
What
Explain that
deployment.environmentdoes not impact service identity.References
Fixes #119
Merge requirement checklist