Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional details to the readme #1

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

codeboten
Copy link
Contributor

No description provided.

Signed-off-by: Alex Boten <aboten@lightstep.com>
README.md Outdated Show resolved Hide resolved
@cartersocha
Copy link
Contributor

@reyang needs to be added as a maintainer too

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the Slack channel renaming is taken into account.

Co-authored-by: Tyler Benson <tylerbenson@gmail.com>
@codeboten
Copy link
Contributor Author

LGTM, once the Slack channel renaming is taken into account.

I have no idea when that rename happened, i created the readme and #otel-security was still there

@jpkrohling
Copy link
Member

jpkrohling commented Jul 18, 2023

It happened after you opened the PR and before I reviewed it :-)

@jpkrohling jpkrohling merged commit 2eeccbb into open-telemetry:main Jul 18, 2023
@cartersocha
Copy link
Contributor

@codeboten I did it today. Wanted to wait until we had a confirmed repo name / brand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants