Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use crates.io #961

Merged
merged 7 commits into from
Nov 7, 2023
Merged

use crates.io #961

merged 7 commits into from
Nov 7, 2023

Conversation

xlc
Copy link
Member

@xlc xlc commented Oct 25, 2023

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #961 (5f3014a) into master (83a76c2) will increase coverage by 0.15%.
The diff coverage is 97.43%.

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
+ Coverage   84.98%   85.13%   +0.15%     
==========================================
  Files          88       88              
  Lines       10063    10073      +10     
==========================================
+ Hits         8552     8576      +24     
+ Misses       1511     1497      -14     
Files Coverage Δ
asset-registry/src/migrations.rs 85.71% <100.00%> (ø)
asset-registry/src/mock/para.rs 78.37% <ø> (+7.64%) ⬆️
asset-registry/src/mock/relay.rs 10.00% <ø> (ø)
authority/src/mock.rs 81.25% <ø> (ø)
currencies/src/mock.rs 94.11% <ø> (ø)
tokens/src/imbalances.rs 22.50% <100.00%> (+8.61%) ⬆️
tokens/src/tests_currency_adapter.rs 100.00% <100.00%> (ø)
unknown-tokens/src/migrations.rs 88.63% <100.00%> (ø)
vesting/src/mock.rs 100.00% <ø> (ø)
vesting/src/tests.rs 100.00% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@zjb0807 zjb0807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions of the pallet are different. Will it be more troublesome to upgrade in the future? Check it one by one?

tokens/src/mock.rs Show resolved Hide resolved
@xlc
Copy link
Member Author

xlc commented Nov 7, 2023

paritytech/diener#42 should solve the problem.

I am currently using https://marketplace.visualstudio.com/items?itemName=serayuzgur.crates to ensure they are all latest version

@xlc xlc merged commit 0abce5c into master Nov 7, 2023
4 checks passed
@xlc xlc deleted the use-crates-io branch November 7, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants