Fix: #894: Progress Bar shown on top of Input Fields #917
Conversation
|
@miPlodder, can you provide further feedback on my solution (ex. the location of the solution). I would like to be able to improve the quality and clarity of my solution as much as possible! |
app/src/main/java/org/mifos/mobilebanking/ui/fragments/BeneficiaryApplicationFragment.java
Outdated
Show resolved
Hide resolved
| @@ -78,6 +80,7 @@ public void onError(Throwable e) { | |||
| public void onNext(BeneficiaryTemplate beneficiaryTemplate) { | |||
| getMvpView().hideProgress(); | |||
| getMvpView().showBeneficiaryTemplate(beneficiaryTemplate); | |||
| getMvpView().setVisibility(View.VISIBLE); | |||
There was a problem hiding this comment.
Add this inside onComplete()
There was a problem hiding this comment.
@miPlodder I addressed your change 😄
There was a problem hiding this comment.
Remove this from onNext()
There was a problem hiding this comment.
@miPlodder I now see what you mean, I am using the methods innocrectly, onNext() does work to prepare the UI, and onComplete() finishes the process
| @Override | ||
| public void showProgress() { | ||
| showProgressBar(); | ||
|
|
There was a problem hiding this comment.
@miPlodder I addressed your change 😄
|
@miPlodder I added the last bit of your edits, can you resolve the issue and make sure my request is ready for merging? |
Fixes #894
My solution makes sure that the progress bar is never laid on top of the UI. I achieved this functionality by hiding the UI, whenever the loading spinner is been called to show its progress, and then redisplaying the UI after the UI has loaded up.