Fix: macOS ADIOS1 w/ cctools ld64 w/o XCode #1196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
commented
Feb 7, 2022
CMakeLists.txt
Outdated
| @@ -563,6 +563,11 @@ if(openPMD_HAVE_ADIOS1) | |||
| set_target_properties(openPMD.ADIOS1.Serial PROPERTIES | |||
| LINK_FLAGS "-Wl,--exclude-libs,ALL") | |||
| elseif("${CMAKE_SYSTEM_NAME}" MATCHES "Darwin") | |||
| check_linker_flag(CXX "-Wl,--exclude-libs,ALL" DARWIN_WO_XCODE) | |||
There was a problem hiding this comment.
This might be a CMake 3.18+ feature:
- https://gitlab.kitware.com/cmake/cmake/-/merge_requests/4777
- https://cmake.org/cmake/help/latest/module/CheckLinkerFlag.html
Thus:
- need to bump CMake dependency from 3.15+ to 3.18+
There was a problem hiding this comment.
Also: should use LINKER::
Expands to -Wl,--... on GCC and to -Xlinker --... on Clang.
ax3l
force-pushed
the
fix-macOSwithNonXcodeSymbolHidingADIOS1
branch
8 times, most recently
from
ec470ef
to
f6ed2ef
Compare
ax3l
force-pushed
the
fix-macOSwithNonXcodeSymbolHidingADIOS1
branch
2 times, most recently
from
478aade
to
972498c
Compare
ax3l
commented
Feb 8, 2022
| @@ -459,6 +459,7 @@ set(IO_SOURCE | |||
| set(IO_ADIOS1_SEQUENTIAL_SOURCE | |||
| src/Error.cpp | |||
| src/auxiliary/Filesystem.cpp | |||
| src/auxiliary/JSON.cpp | |||
There was a problem hiding this comment.
Needed because TracingJSON is now used in CommonADIOS1IOHandler.cpp
ax3l
force-pushed
the
fix-macOSwithNonXcodeSymbolHidingADIOS1
branch
2 times, most recently
from
9443d4b
to
3a15872
Compare
ax3l
commented
Feb 8, 2022
| src/ChunkInfo.cpp | ||
| src/IO/ADIOS/CommonADIOS1IOHandler.cpp | ||
| src/IO/ADIOS/ADIOS1IOHandler.cpp) | ||
| src/IO/ADIOS/ADIOS1IOHandler.cpp | ||
| src/IO/IOTask.cpp) |
There was a problem hiding this comment.
Needed because we use openPMD::internal::operationAsString in CommonADIOS1IOHandler.cpp
ax3l
force-pushed
the
fix-macOSwithNonXcodeSymbolHidingADIOS1
branch
3 times, most recently
from
59380d0
to
97cdc99
Compare
ax3l
changed the title
Some compiler toolchains on macOS do not use the XCode system compiler. For instance, conda-forge uses vanilla clang to build packages. In that case, the symbol hiding instructions we used on macOS were not effective, leading to errors like openPMD#1195. The current patch checks if the toolchain understands GCC/LLVM-ish linker flags on macOS and if it does, it adds them.
ax3l
force-pushed
the
fix-macOSwithNonXcodeSymbolHidingADIOS1
branch
from
97cdc99
to
8e2e327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compiler toolchains on macOS do not use the XCode tools. For instance, conda-forge uses vanilla clang to build packages combined with a cctools
ld64(similar to the macOS system linker) but without XCode.In that case, the symbol hiding instructions we used on macOS were not effective, leading to errors like #1195.
This also fixes regressions from #1101, similar to #1167.
The current patch checks if the toolchain understands GCC/LLVM/ld64-ish linker flags on macOS and if it does, it adds them.
Attention
llvm-strip< 14 is also broken, which is used in Conda-Forgecompilers-CMAKE_STRIPshould usecctools'stripcommand (needs to be set manually): Conda: llvm-strip <= 13 broken on Apple aarch64 M1 AMReX-Codes/pyamrex#35