Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Sequence instead of List #290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Accept Sequence instead of List #290

wants to merge 1 commit into from

Commits on Sep 14, 2022

  1. Accept Sequence instead of List 

    This is minor, I know. `tokenize` simply iterates over `texts`, so in addition to `list`, `tuple` is fine. The intended type hint for this is `Sequence`.

I am not sure which version of Python this project targets, but judging from the other type hints in this file, I am going to assume `<3.9`. Otherwise, I would suggest importing `Sequence` from `collections.abc` instead of `typing`.
    @jangop
    jangop authored Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b118307 View commit details
    Browse the repository at this point in the history