More scripts #61
Merged
More scripts #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heewooj
reviewed
May 11, 2020
| models the lyrics, and we use its last layer to produce keys/values that are attened to by the decoder transformer | ||
| - Single Encoder Decoder: This is a simplification where we combine them into a single model. We merge the text vocab | ||
| and VQ vocab into a single large vocab, and the lyric tokens and VQ tokens into a single longer sequence of tokens which | ||
| we autoregressively model together. |
heewooj
reviewed
May 11, 2020
README.md
Outdated
| mpiexec -n {ngpus} python jukebox/train.py --hps=vqvae,small_prior,all_fp16,cpu_ema --name=pretrained_vqvae_small_prior_labels \ | ||
| --sample_length=1048576 --bs=4 --aug_shift --aug_blend --audio_files_dir={audio_files_dir} \ | ||
| --labels=True --train --test --prior --levels=3 --level=2 --weight_decay=0.01 --save_iters=1000 \ | ||
| --labels_v3=True --y_bins=({artists},{genres}) --max_bow_genre_size=1 --min_duration=60.0 --max_duration=600.0 --t_bins=64 |
There was a problem hiding this comment.
might be useful to add that --min_duration --max_duration should be decided based on the dataset people have, and that --min_duration should be at least ~23.8 seconds so that there's always a context we can train on.
heewooj
reviewed
May 11, 2020
jukebox/hparams.py
Outdated
| n_ctx=6144, | ||
| prior_width=1024, | ||
| prior_depth=48, | ||
| heads=4, |
There was a problem hiding this comment.
nitpick: in general, lgtm, but perhaps, 2 heads will be enough? 1B lyrics uses 2 heads as well
There was a problem hiding this comment.
good point, changing!
heewooj
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.