This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Minor, but relevant docs updates #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binwiederhier
commented
Jul 27, 2021
| @@ -113,17 +113,17 @@ Assuming this topology: | |||
| ``` | |||
|
|
|||
| `orchestrator` would detect a [`MasterWithTooManySemiSyncReplicas`](failure-detection.md#masterwithtoomanysemisyncreplicas) scenario | |||
| and disable semi-sync on replica2. | |||
| and disable semi-sync on replica1 (lower priority). | |||
There was a problem hiding this comment.
This is the only major thing. The rest are cosmetic changes.
shlomi-noach
approved these changes
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wouldn't bother updating the docs for the other stuff, but the conclusion of "Example 1" is incorrect: it should be "... and disable semi-sync on replica1 ..." (not: replica2). That may confuse a lot of people if we don't correct this