Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename refers field to subject #344

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

sajayantony
Copy link
Member

Fixes correspond to the the image spec changes

Signed-off-by: Sajay Antony sajaya@microsoft.com

@sajayantony sajayantony changed the title Rename refers field to subbject Rename refers field to subject Sep 13, 2022
jdolitsky
jdolitsky previously approved these changes Sep 13, 2022
dmcgowan
dmcgowan previously approved these changes Sep 13, 2022
@sudo-bmitch
Copy link
Contributor

CI should be fixed if this is rebased.

vbatts
vbatts previously approved these changes Sep 14, 2022
Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Fixes correspond to the the image spec changes
- opencontainers/image-spec#950

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
@sajayantony
Copy link
Member Author

Rebased and CI is now passing.
Please help review this again @vbatts @sudo-bmitch @dmcgowan @jdolitsky.

Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky jdolitsky merged commit 1d506c4 into opencontainers:main Sep 14, 2022
@mikebrow
Copy link
Member

reads much better, I think.. Thx @sajayantony

@sajayantony sajayantony deleted the rename-to-subject branch September 14, 2022 18:21
@jdolitsky jdolitsky mentioned this pull request Sep 15, 2022
@sudo-bmitch sudo-bmitch mentioned this pull request Feb 1, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants