Add a patch status to recover failed requests #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe and
vbatts
as code owners
jdolitsky
approved these changes
Dec 1, 2022
|
@opencontainers/distribution-spec-maintainers any objections to merging? |
vbatts
reviewed
Mar 19, 2023
|
|
||
| ``` | ||
| Location <location> | ||
| Location: <location> | ||
| Range: 0-<end-of-range> |
There was a problem hiding this comment.
for this to be a new "MUST", do we have an idea of whether registries are already doing this?
There was a problem hiding this comment.
That got pulled in from the Docker Registry spec, so anyone implementing that would already be doing this.
vbatts
approved these changes
Mar 22, 2023
This was referenced Apr 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brandon Mitchell git@bmitch.net
Fixes #353.
This defines the get blob upload API from the Docker spec, which is needed to recover an interrupted patch request when the client and server state get out of sync. It also includes updated conformance tests. Fixes to these APIs were recently added in distribution/distribution PR 3755.