Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to reggie v0.6.1 to fix issue with Accept header #400

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

jdolitsky
Copy link
Member

Resolves #396

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@sudo-bmitch
Copy link
Contributor

@Dylmay PTAL

@Dylmay
Copy link

Dylmay commented Apr 5, 2023

Can confirm that it's fixed the problem. The accept header is no longer incorrectly set and the PUT is successful

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky jdolitsky merged commit e79ab90 into opencontainers:main Apr 6, 2023
@jdolitsky jdolitsky deleted the accept-header branch April 6, 2023 14:20
@jdolitsky jdolitsky mentioned this pull request Apr 19, 2023
@sudo-bmitch sudo-bmitch mentioned this pull request Feb 1, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conformance Test: 'Accept' header set during manifest put
4 participants