Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libct: rm initWaiter #4441

Merged
merged 1 commit into from
Oct 18, 2024
Merged

libct: rm initWaiter #4441

merged 1 commit into from
Oct 18, 2024

Conversation

kolyshkin
Copy link
Contributor

This initWaiter logic was introduced by commit 4ecff8d (PR #2855), but since the logic of /proc/self/exe was moved out of runc init in commit 0e9a335 (PR #3987), this seems unnecessary to have initWaiter.

Remove it.

This essentially reverts commit 4ecff8d.

@kolyshkin kolyshkin marked this pull request as ready for review October 12, 2024 00:54
@lifubang
Copy link
Member

Please see #4438 (comment)

This initWaiter logic was introduced by commit 4ecff8d, but since the logic of
/proc/self/exe was moved out of runc init in commit 0e9a335, this
seems unnecessary to have initWaiter.

Remove it.

This essentially reverts commit 4ecff8d.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

No longer a draft. @cyphar @rata PTAL

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cyphar cyphar merged commit 2664c84 into opencontainers:main Oct 18, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants