Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Namespaces to use LinuxNamespaceType #1007

Merged
merged 1 commit into from
May 7, 2019
Merged

Fix Namespaces to use LinuxNamespaceType #1007

merged 1 commit into from
May 7, 2019

Conversation

KentaTada
Copy link
Contributor

@KentaTada KentaTada commented Apr 19, 2019 •
edited
Loading

LinuxNamespaceType is defined but it is only used for PIDNamespace.
I think all Namespaces should use this type.

Signed-off-by: Kenta Tada Kenta.Tada@sony.com

Fix Namespaces to use LinuxNamespaceType
fbda535 
Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
@KentaTada
Copy link
Contributor Author

Could you review this commit? cc @vbatts @crosbymichael @cyphar @alban
BTW, I don't know why checks were failed although "Signed-off-by" was added.

@tianon
Copy link
Member

tianon commented May 7, 2019 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

thaJeztah
thaJeztah approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not a maintainer)

@crosbymichael
Copy link
Member

crosbymichael commented May 7, 2019 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 5b71a03 into opencontainers:master May 7, 2019
@vbatts vbatts mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KentaTada @tianon @crosbymichael @thaJeztah