Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specs-go/config: add keyring support #1112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

specs-go/config: add keyring support #1112

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a35229
specs-go/config: add keyring support
kailun-qin Aug 3, 2021
fa28902
Update keyring support docs
kailun-qin Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
specs-go/config: add keyring support 
Currently, with `runc` we have a special cmdline flag `--no-new-keyring`
for `runc run` that enables/disables the creation of a new kernel
keyring. The main reason we have the option is that older kernels had
issues with allocating a lot of keyrings (so in order to run containers
on old kernels you need to disable the creation of a new keyring).

This patch adds keyring support into part of the OCI spec which allows
managers to drive this behavior in a runtime-agnostic way and helps make
swapping in other runtimes easier.

Fixes #754
Fixes #950

Signed-off-by: Kailun Qin <kailun.qin@intel.com>
  • Loading branch information
@kailun-qin
kailun-qin committed Aug 3, 2021
commit 0a352294ffeca35798503af7f65e9dd2a0473357
34 changes: 34 additions & 0 deletions specs-go/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ type Linux struct {
IntelRdt *LinuxIntelRdt `json:"intelRdt,omitempty"`
// Personality contains configuration for the Linux personality syscall
Personality *LinuxPersonality `json:"personality,omitempty"`
// Keyrings specifies the kernel keyrings that are created and/or joined by the container.
Keyrings *LinuxKeyrings `json:"keyrings,omitempty"`
}

// LinuxNamespace is the configuration for a Linux namespace
Expand Down Expand Up @@ -431,6 +433,38 @@ type LinuxPersonality struct {
Flags []LinuxPersonalityFlag `json:"flags,omitempty"`
}

// LinuxKeyrings specifies the list of keyrings used to anchor keys on behalf of a process.
// https://man7.org/linux/man-pages/man7/keyrings.7.html
type LinuxKeyrings struct {
// Session is the session shared process keyring.
// It is inherited and shared by all child processes.
Session LinuxSessionKeyring `json:"session,omitempty"`
// Process is the per-process shared keyring.
// It is shared by all threads in a process.
Process LinuxProcessKeyring `json:"process,omitempty"`
// Session is the per-thread keyring.
// It is specific to a particular thread.
Thread LinuxThreadKeyring `json:"thread,omitempty"`
}

// LinuxSessionKeyring defines the session shared process keyring.
type LinuxSessionKeyring struct {
// Name is the name of the session-specific keyring.
Name string `json:"name,omitempty"`
}

// LinuxProcessKeyring defines the per-process shared keyring.
type LinuxProcessKeyring struct {
// Name is the name of the process-specific keyring.
Name string `json:"name,omitempty"`
}

// LinuxThreadKeyring defines the per-thread keyring.
type LinuxThreadKeyring struct {
// Name is the name of the thread-specific keyring.
Name string `json:"name,omitempty"`
}

// Solaris contains platform-specific configuration for Solaris application containers.
type Solaris struct {
// SMF FMRI which should go "online" before we start the container process.
Expand Down