Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update associated projects #328

Merged

Conversation

hqhq
Copy link
Contributor

@hqhq hqhq commented Mar 1, 2016

Now we have ocitools in opencontainers, thanks @mrunalp .

Signed-off-by: Qiang Huang h.huangqiang@huawei.com


## Testing

* [opencontainers/ocitools](https://github.com/opencontainers/ocitools) - A config generator and runtime testing framework.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on intended scoping for this project, but there's an in-flight PR for bundle validation as well (opencontainers/runtime-tools#20) that hasn't been closed as “out of scope”. So probably list bundle testing as well, unless we want to file a follow-up PR adding it if/when the ocitools PR lands.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the plan is we(huawei guys) will backport as many features as we can from oct to ocitools, then we can remove oct here and rewrite the scope of ocitools. Or maybe @mrunalp can give a better description of scope for ocitools now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, 'testing&tools' is a better description here.

I think @mrunalp agreed ocitools should cover three areas currently.(I cannot find the related conversation in issue/PR)

  1. generate
  2. bundle validate
  3. runtime validate

@mrunalp
Copy link
Contributor

mrunalp commented Mar 1, 2016

@liangchenye Yes, those are the initial tools and we could always add more tooling as the project evolves.

@mrunalp
Copy link
Contributor

mrunalp commented Mar 16, 2016

@hqhq Can you update the PR?

@wking
Copy link
Contributor

wking commented Mar 16, 2016

While we're touching these references, maybe drop in a reference to
jfrazelle/riddler (mentioned on IRC on Monday 1).

@crosbymichael
Copy link
Member

Where do we draw the line of what is added to this list? I don't see it as a scale-able thing to have in the repo. Are we just going to link to anything and everything?

@mrunalp
Copy link
Contributor

mrunalp commented Mar 16, 2016

@crosbymichael Maybe we could just provide a pointer to opencontainer/ocitools (Since it will be supported and updated to keep up with the spec) and keep the rest in a wiki?

@crosbymichael
Copy link
Member

Ya, it would probably be better to just have the official repositories here if anything at all. If you think about it, if we add just any repo what uses or consumes the spec it will be a never ending battle of one line prs to add some repo that we know nothing about. The title is "associated" projects implying that we are associated with these things when that is not the case.

I wiki could scale better but I have not used github wikis so I don't know how well it works.

@wking
Copy link
Contributor

wking commented Mar 16, 2016

On Wed, Mar 16, 2016 at 03:01:07PM -0700, Michael Crosby wrote:

If you think about it, if we add just any repo what uses or consumes
the spec it will be a never ending battle of one line prs to add
some repo that we know nothing about.

I'm fine with an open door (punting on curation) until we have at
least twenty or so referenced projects here ;). Any consumer that a
spec maintainer links to on IRC sounds like fair game for curation
anyway.

Now we have ocitools in opencontainers, thanks @mrunalp .

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@hqhq hqhq force-pushed the hq_update_associated_projects branch from b32bb1f to fd37635 Compare March 18, 2016 06:07
@hqhq
Copy link
Contributor Author

hqhq commented Mar 18, 2016

Updated the description of ocitools.

@vbatts
Copy link
Member

vbatts commented Mar 18, 2016

sadly, the CI failures are unrelated. I opened #350 to track that separately.

@vbatts
Copy link
Member

vbatts commented Mar 18, 2016

LGTM

1 similar comment
@crosbymichael
Copy link
Member

LGTM

crosbymichael added a commit that referenced this pull request Mar 18, 2016
@crosbymichael crosbymichael merged commit 7aeccd7 into opencontainers:master Mar 18, 2016
@hqhq hqhq deleted the hq_update_associated_projects branch March 19, 2016 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants