Makefile: add target for tools #349
Conversation
| .PHONY: docs | ||
| docs: pdf html |
There was a problem hiding this comment.
Since you're touching these targets, maybe adjust the pdf and html targets to actual filenames (output/docs.pdf?) or mark them phony as well. If you go the filename route, you'll want to specify prerequisites for both targets.
vbatts
force-pushed
the
target-install-tools
branch
from
db96e57
to
a79fdef
Compare
vbatts
force-pushed
the
target-install-tools
branch
3 times, most recently
from
70be85b
to
0e4425f
Compare
vbatts
force-pushed
the
target-install-tools
branch
from
0e4425f
to
8f70c5f
Compare
|
Updated, fixed and rebased. PTAL. |
|
|
||
| # golint does not even build for <go1.5 | ||
| .install.golint: | ||
| ifeq ($(call ALLOWED_GO_VERSION,1.5,$(HOST_GOLANG_VERSION)),true) |
There was a problem hiding this comment.
There was a problem hiding this comment.
it's being used on the install of go vet, and someone's local go version
may vary.
On Tue, Apr 12, 2016 at 1:11 AM, W. Trevor King notifications@github.com
wrote:
In Makefile
#349 (comment)
:git-validation -q -run DCO,short-subject -v -range $(EPOCH_TEST_COMMIT)..HEAD+.PHONY: install.tools
+install.tools: .install.golint .install.govet .install.gitvalidation
+
+# golint does not even build for <go1.5
+.install.golint:
+ifeq ($(call ALLOWED_GO_VERSION,1.5,$ (HOST_GOLANG_VERSION)),true)We can probably just remove the ALLOWED_GO_VERSION stuff, since c506ce6
c506ce6
(Fix the build by getting rid of go get for vet, 2016-04-07, #372
#372) completely
dropped Go < 1.5. We can always drag it out of the PR history if we need
that sort of logic to partially support Go 1.5 (or whatever) in the future.—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/runtime-spec/pull/349/files/8f70c5f3d3a7b083248ca79edd1b9a261da4de09#r59321441
There was a problem hiding this comment.
On Tue, Apr 12, 2016 at 06:49:07AM -0700, Vincent Batts wrote:
it's being used on the install of go vet, and someone's local go
version may vary.
Ah, good point. I guess folks might be running these checks outside
of Travis ;).
|
LGTM |
As we have several tools used in the Makefile, might as well make them easier to install. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
vbatts
force-pushed
the
target-install-tools
branch
from
8f70c5f
to
c4b846c
Compare
As we have several tools used in the Makefile, might as well make them
easier to install.
Signed-off-by: Vincent Batts vbatts@hashbangbash.com