-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: add a README #360
schema: add a README #360
Conversation
|
||
The layout of the files is as follows: | ||
* schema.json - the primary entrypoint for the whole schema document | ||
* schema-linux.json - this schema is for the Linux specific sub structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“Linux-specific sub-structures”?
* defs.json - definitions for general types | ||
* defs-linux.json - definitions for Linux-specific types | ||
* validate.go - validation utility source code | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
5bba104
to
f040e1f
Compare
f040e1f looks good to me.
|
LGTM |
validating the `config.json` of this container runtime specification. | ||
|
||
The layout of the files is as follows: | ||
* schema.json - the primary entrypoint for the whole schema document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add links to these files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Super helpful. Thanks for this PR @vbatts !! LGTM |
validating the `config.json` of this container runtime specification. | ||
|
||
The layout of the files is as follows: | ||
* [schema.json](./schema.json) - the primary entrypoint for the whole schema document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pedantic nit: the other link targets don't have a leading ./
, so maybe remove this one for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
muscle memory. fixed.
On Wed, Apr 13, 2016 at 1:43 PM, W. Trevor King notifications@github.com
wrote:
In schema/README.md
#360 (comment)
:@@ -0,0 +1,32 @@
+# JSON schema
+
+## Overview
+
+This directory contains the JSON Schema for
+validating theconfig.json
of this container runtime specification.
+
+The layout of the files is as follows:
+* schema.json - the primary entrypoint for the whole schema documentPedantic nit: the other link targets don't have a leading ./, so maybe
remove this one for consistency?—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/runtime-spec/pull/360/files/57d2484193eb1631c186f308cf65c1f0fac43952#r59592283
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Vincent Batts vbatts@hashbangbash.com