-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: git-validation detects travis now #366
Conversation
hmm. something strange happened in those failures... |
ah. found it. vbatts/git-validation#6 |
cool. PTAL. |
but now why isn't this being tested?!? |
woah. it had been. though github was seeming to choke up a bit ago. |
https://travis-ci.org/opencontainers/runtime-spec/builds/120966194 ? |
@caniszczyk any thoughts? ^^ |
I just kicked it again, looks good? https://travis-ci.org/opencontainers/runtime-spec/builds/120966194 |
@caniszczyk the build is fine, but not sure why travis status is no longer showing on PRs. I'm wondering if the project rename did not sync with travis? |
@vbatts ah you're right, wth! up for creating another PR to see if the issue fixed itself with a new PR? I completely refreshed the Travis CI settings for the repos so not sure what's up yet. |
looks to be back. Thanks @caniszczyk |
PTAL |
|
||
install: true | ||
|
||
script: | ||
- go vet -x ./... | ||
- make .golint | ||
- $HOME/gopath/bin/git-validation -run DCO,short-subject -v -range ${TRAVIS_COMMIT_RANGE} | ||
- git-validation -run DCO,short-subject -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe want dangling-whitespace
too (from vbatts/git-validation#7), although that somewhat of a drive-by with this PR. Still, it would be nice to avoid things like #380.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR should fix travis failures like this https://travis-ci.org/opencontainers/runtime-spec/jobs/122597352 |
LGTM |
Needs rebase. |
The `-range` argument is not needed. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
LGTM |
Signed-off-by: Vincent Batts vbatts@hashbangbash.com