config: Move (u|g)idMappings from 'process' to 'linux' #390
Conversation
To match where they're defined in the JSON Schema [1]. The old location is from d4e7326 (config: JSON examples, 2016-04-06, opencontainers#370), and seems to have been accidental. [1]: https://github.com/opencontainers/runtime-spec/blob/0982071b288ddddc1ae84d21c4bd682c96942f5c/schema/schema-linux.json#L21-L48 Signed-off-by: W. Trevor King <wking@tremily.us>
| { | ||
| "hostID": 1000, | ||
| "containerID": 0, | ||
| "size": 32000 |
There was a problem hiding this comment.
32000 looks like a non sense magic number, 32768 might be better, what do you think?
There was a problem hiding this comment.
On Wed, Apr 20, 2016 at 07:23:00PM -0700, Qiang Huang wrote:
@@ -463,6 +449,20 @@ Here is a full example
config.jsonfor reference.
"gid": 0
}
],
"uidMappings": [{"hostID": 1000,"containerID": 0,"size": 3200032000 looks like a non sense magic number, 32768 might be better, what do you think?
This PR is just about moving the existing example to the right place,
not about adjusting the example content.
If you want to file a separate issue/PR adjusting the number, that
size is from #370 based on @mrunalp's “32k” suggestion 1. I'm happy
with anything > 0 and still well short of overflowuid.
There was a problem hiding this comment.
I'm OK if we do this in a separate PR, I think 32k is supposed to be 32768.
|
LGTM |
1 similar comment
|
LGTM |
To match where they're defined in the JSON Schema. The old
location is from d4e7326 (config: JSON examples, 2016-04-06, #370),
and seems to have been accidental.