Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROADMAP: Remove stale targets (landed PRs, image-spec, ocitools, etc.) #435

Merged
merged 1 commit into from
May 18, 2016

Conversation

wking
Copy link
Contributor

@wking wking commented May 13, 2016

This PR cherry-picks the first two from #423 and adds additional
target-removal commits with the reasoning I posted to the list.
I'm happy to pull out any contentious and/or obvious commits into
separate PRs if that makes reviewing and landing this easier.

@crosbymichael
Copy link
Member

This did not need to be 6 commits

@wking
Copy link
Contributor Author

wking commented May 13, 2016

On Fri, May 13, 2016 at 01:13:47PM -0700, Michael Crosby wrote:

This did not need to be 6 commits

I can squash if you like, but having six commits gave a convenient
place to motivate each removal, and I wasn't sure they would all be
picked up. If they do all look good and you want me to squash, I can
always use sub-headings in a single commit message. Just tell me what
you want ;).

@vbatts
Copy link
Member

vbatts commented May 15, 2016

Squash them

On Fri, May 13, 2016 at 3:33 PM, W. Trevor King notifications@github.com
wrote:

On Fri, May 13, 2016 at 01:13:47PM -0700, Michael Crosby wrote:

This did not need to be 6 commits

I can squash if you like, but having six commits gave a convenient
place to motivate each removal, and I wasn't sure they would all be
picked up. If they do all look good and you want me to squash, I can
always use sub-headings in a single commit message. Just tell me what
you want ;).


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#435 (comment)

# digest/hashing target

Most of this has spun off with [1], and I haven't heard of anyone
talking about verifying the on-disk filesystem in a while.  My
personal take is on-disk verification doesn't add much over serialized
verification unless you have a local attacker (or unreliable disk),
and you'll need some careful threat modeling if you want to do
anything productive about the local attacker case.  For some more
on-disk verification discussion, see the thread starting with [2].

# distributable-format target

This spun off with [1].

# lifecycle target

I think this is resolved since 7713efc (Add lifecycle for containers,
2015-10-22, opencontainers#231), which was committed on the same day as the ROADMAP
entry (4859f6d, Add initial roadmap, 2015-10-22, opencontainers#230).

# container-action target

Addressed by 7117ede (Expand on the definition of our ops,
2015-10-13, opencontainers#225), although there has been additional discussion in
a7a366b (Remove exec from required runtime functionalities,
2016-04-19, opencontainers#388) and 0430aaf (Split create and start, 2016-04-01,
opencontainers#384).

# validation and testing targets

Validation is partly covered by cdcabde (schema: JSON Schema and
validator for `config.json`, 2016-01-19, opencontainers#313) and subequent JSON
Schema work.  The remainder of these targets are handled by ocitools
[3].

# printable/compiled-spec target

The bulk of this was addressed by 4ee036f (*: printable documents,
2015-12-09, opencontainers#263).  Any remaining polishing of that workflow seems
like a GitHub-issue thing and not a ROADMAP thing.  And publishing
these to opencontainers.org certainly seems like it's outside the
scope of this repository (although I think that such publishing is a
good idea).

[1]: https://github.com/opencontainers/image-spec
[2]: https://groups.google.com/a/opencontainers.org/d/msg/dev/xo4SQ92aWJ8/NHpSQ19KCAAJ
     Subject: OCI Bundle Digests Summary
     Date: Wed, 14 Oct 2015 17:09:15 +0000
     Message-ID: <CAD2oYtN-9yLLhG_STO3F1h58Bn5QovK+u3wOBa=t+7TQi-hP1Q@mail.gmail.com>
[3]: https://github.com/opencontainers/ocitools

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking
Copy link
Contributor Author

wking commented May 15, 2016

On Sun, May 15, 2016 at 11:28:29AM -0700, Vincent Batts wrote:

Squash them

Squashed with a45289c23e03f9.

@crosbymichael
Copy link
Member

LGTM

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented May 18, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants