Makefile: prefer bash #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opencontainers#454 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
LGTM |
1 similar comment
|
LGTM |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Aug 26, 2016
With dash 0.5.7: # make docs /bin/sh: 1: test: 1.3.3: unexpected operator /bin/sh: 1: test: 1.3.3: unexpected operator /bin/sh: 1: test: 1.3.3: unexpected operator Makefile:47: *** cannot build output//oci-runtime-spec.pdf without either pandoc or docker. Stop. # command -V test test is a shell builtin POSIX defines '=' for string comparison [1]; the '==' form is a Bashism. SHELL was added in f3fdf03 (Makefile: prefer bash, 2016-05-25, opencontainers#455) to avoid these "unexpected operator" errors, but there's no reason to require Bash when we can make the comparison's POSIX compliant. [1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#454
Signed-off-by: Vincent Batts vbatts@hashbangbash.com