Makefile: filename docs.* -> oci-runtime-spec.*

[vbatts]

When this repo was only 'specs', then the generic name was not so bad.
But now there is also the oci-image-spec, so this lines up it's unique
name as well.

This also variablizes the output filename so it will be easier for
release specific names.

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

[wking]

This is pretty similar to PANDOC_DST. It's probably better to combine them into a single variable.

[vbatts]

fair

[vbatts]

Well, no. They're similar, but not the same.

[wking]

On Wed, Jun 01, 2016 at 11:58:45AM -0700, Vincent Batts wrote:

@@ -1,14 +1,17 @@

-SHELL ?= $(shell command -v bash 2>/dev/null)
-DOCKER ?= $(shell command -v docker 2>/dev/null)
-PANDOC ?= $(shell command -v pandoc 2>/dev/null)
+EPOCH_TEST_COMMIT := 78e6667
+OUTPUT_DIRNAME ?= output/

Well, no. They're similar, but not the same.

Right. I think they should be unified into a single variable, but
that unification will take a bit of thinking to figure out.

[vbatts]

so, not in this PR ;-)

On Wed, Jun 1, 2016 at 3:01 PM, W. Trevor King notifications@github.com
wrote:

In Makefile
#478 (comment)
:

@@ -1,14 +1,17 @@

-SHELL ?= $(shell command -v bash 2>/dev/null)
-DOCKER ?= $(shell command -v docker 2>/dev/null)
-PANDOC ?= $(shell command -v pandoc 2>/dev/null)
+EPOCH_TEST_COMMIT := 78e6667
+OUTPUT_DIRNAME ?= output/

On Wed, Jun 01, 2016 at 11:58:45AM -0700, Vincent Batts wrote: > @@ -1,14
+1,17 @@ > > -SHELL ?= $(shell command -v bash 2>/dev/null) > -DOCKER ?=
$(shell command -v docker 2>/dev/null) > -PANDOC ?= $(shell command -v
pandoc 2>/dev/null) > +EPOCH_TEST_COMMIT := 78e6667
78e6667

+OUTPUT_DIRNAME ?= output/ Well, no. They're similar, but not the same.
Right. I think they should be unified into a single variable, but that
unification will take a bit of thinking to figure out.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opencontainers/runtime-spec/pull/478/files/f656de6a567f016eed7f838d491b27097ad60dd9#r65422302,
or mute the thread
https://github.com/notifications/unsubscribe/AAEF6ZPvLh0a8XSGyQUmchtY0C_P0iq1ks5qHdcQgaJpZM4Iryg0
.

[wking]

On Wed, Jun 01, 2016 at 12:09:19PM -0700, Vincent Batts wrote:

@@ -1,14 +1,17 @@

-SHELL ?= $(shell command -v bash 2>/dev/null)
-DOCKER ?= $(shell command -v docker 2>/dev/null)
-PANDOC ?= $(shell command -v pandoc 2>/dev/null)
+EPOCH_TEST_COMMIT := 78e6667
+OUTPUT_DIRNAME ?= output/

so, not in this PR ;-)

This PR is landing the new variable. Whether two overlapping
variables is confusing enough to be worth blocking a merge is up to
the maintainers ;). Still unifying them shouldn't be that hard.
Maybe just:

CONTAINER_OUTPUT_DIRNAME = $(OUTPUT_DIRNAME)

here,

CONTAINER_OUTPUT_DIRNAME = /$(OUTPUT_DIRNAME)

inside the ifneq DOCKER block, and PANDOC_DST →
CONTAINER_OUTPUT_DIRNAME in the rules?

[crosbymichael]

LGTM

[hqhq]

LGTM