-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go 1.20 support; require Go 1.19; drop Go 1.17 and 1.18 #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that those jobs that explicitly use go 1.19 should switch to 1.20 as well.
Also, maybe we can drop go 1.17 support, as this is not supported by upstream since go 1.19 is released half a year ago; @rhatdan what do you think?
I agree we should move to 1.19 and 1.20 |
726a716
to
23a10a9
Compare
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
23a10a9
to
f257026
Compare
I had missed bumping the version for test-stubs/golangci-lint. Should be addressed now. |
LGTM |
Oh it looks like I have confused the GitHub UI. Right now it is showing the Go 1.17 and 1.18 checks as pending, but we have removed those from the testing matrix. So really the checks are green right now. |
@kolyshkin @thaJeztah PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(I've changed the list of CI jobs required for merge -- removed older versions, added 1.20.x) |
LGTM |
Signed-off-by: Austin Vazquez macedonv@amazon.com