Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some error #200

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix some error #200

merged 1 commit into from
Aug 7, 2023

Conversation

ningmingxiao
Copy link
Contributor

No description provided.

@ningmingxiao
fix some obvious error
ea3905d 
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
@ningmingxiao ningmingxiao changed the title delete useless code fix some error Jul 28, 2023
@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Jul 31, 2023 •
edited
Loading

ping @thaJeztah @rhatdan

@rhatdan
Copy link
Collaborator

rhatdan commented Jul 31, 2023

LGTM
@kolyshkin PTAL

@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Aug 3, 2023 •
edited
Loading

@thaJeztah Is this pr ok?

@rhatdan
Copy link
Collaborator

rhatdan commented Aug 3, 2023

@giuseppe PTAL

giuseppe
giuseppe approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 37cba3e into opencontainers:main Aug 7, 2023
9 checks passed
@ningmingxiao ningmingxiao deleted the dev1 branch August 8, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

@giuseppe giuseppe giuseppe approved these changes

@kolyshkin kolyshkin Awaiting requested review from kolyshkin kolyshkin is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ningmingxiao @rhatdan @giuseppe @thaJeztah