Fix error when loading custom pricing configuration file #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattray Hi, when you have some time, pls let me know if this looks good to you 🙏 |
mattray
reviewed
May 22, 2024
| @@ -243,7 +243,7 @@ spec: | |||
| readOnly: false | |||
| {{- end }} | |||
| {{- if .Values.opencost.customPricing.enabled }} | |||
| - mountPath: {{ .Values.opencost.customPricing.configPath }} | |||
| - mountPath: {{ .Values.opencost.customPricing.configPath }}/{{ include "opencost.configFileName" . }}.json | |||
| name: custom-configs | |||
| subPath: {{ include "opencost.configFileName" . }}.json | |||
There was a problem hiding this comment.
the subPath isn't working?
There was a problem hiding this comment.
No, it gets mounted as a file:
~ $ ls /tmp/custom-config -l
-rw-r--r-- 1 root root 299 May 15 10:27 /tmp/custom-config
~ $ cat /tmp/custom-config
{
"CPU": "1.25",
"GPU": "0.95",
"RAM": "0.5",
"description": "Modified pricing configuration.",
"internetNetworkEgress": "0.12",
"regionNetworkEgress": "0.01",
"spotCPU": "0.006655",
"spotRAM": "0.000892",
"storage": "0.25",
"zoneNetworkEgress": "0.01",
"provider" : "custom"
}~ $
There was a problem hiding this comment.
As @mogaal said,
The subPath specifies what key should be loaded from the configmap. The mountPath is the full path to the file loaded, so it should also contain the file's name or else the custom-config would be considered as the mounted file's name. Final applied deployment should be like this:
- mountPath: /tmp/custom-config/default.json
name: custom-configs
readOnly: true
subPath: default.json
|
#208 should have the full fix for this, as you need to fix the custom metrics too. |
Signed-off-by: Matt Ray <github@mattray.dev>
mattray
approved these changes
Jun 3, 2024
mattray
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug I reported in #205, where the
CONFIG_PATHdirectory is mounted as a file instead of as a directory:This causes the pod to fail with: